Messages in this thread | | | Date | Fri, 15 Feb 2019 19:12:23 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH 09/10] perf tools: Add perf_topo_cpu object |
| |
On Wed, Feb 13, 2019 at 06:19:35PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Feb 13, 2019 at 01:32:45PM +0100, Jiri Olsa escreveu: > > Making struct cpu_topo global and renaming it to > > struct perf_topo_cpu, so it can be used from record > > command in following patches. > > > > Adding following interface functions to load/free > > cpu topology details: > > struct perf_topo_cpu *perf_topo_cpu__new(void); > > void perf_topo_cpu__free(struct perf_topo_cpu *tp); > > > > Moving it into separate object file cputopo.c together > > with numa related object in following patches. > > > > No functional change, the new interface will be used > > in upcoming changes. > > Please rename it to 'struct cpu_topology' and make its related functions > be cpu_topology__new, the __free() should be __delete() since it doesn't > just free its members, but deletes itself as well. > > I think this is not perf specific at all, so no need for the 'perf' > prefix.
ok, will do
jirka
| |