Messages in this thread | | | Date | Fri, 15 Feb 2019 16:05:06 -0200 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH v2 perf,bpf 09/11] perf-top: add option --bpf-event |
| |
Em Fri, Feb 15, 2019 at 05:06:19PM +0000, Song Liu escreveu: > > On Feb 15, 2019, at 6:27 AM, Arnaldo Carvalho de Melo <acme@redhat.com> wrote: > > Em Thu, Feb 14, 2019 at 04:00:10PM -0800, Song Liu escreveu: > >> bpf events are only tracked when opts->bpf_event is enabled. This patch > >> adds command line flag to enable this for perf-top. > > Shouldn't this start as enabled and we just provide a way to disable it > > for testing purposes? Normally perf top works system wide, and then we > > want to get info about BPF events, I think.
> We can enable it by default, and add a --no-bpf-event option to disable it > for testing.
Excellent, thanks.
- Arnaldo
| |