Messages in this thread | | | Subject | Re: [PATCH 0/2] extcon: Intel Cherry Trail Whiskey Cove PMIC and external charger tweaks | From | Chanwoo Choi <> | Date | Fri, 15 Feb 2019 16:08:23 +0900 |
| |
Hi Yauhen,
You are missing me on cc list. I didn't know this patchset. On next, please use the get_maintainer script in order to send the correct list.
On 19. 2. 11. 오전 5:36, Yauhen Kharuzhy wrote: > At implementation of charging support for Lenovo Yoga Book (Intel Cherry Trail > based with Whiskey Cove PMIC), two pitfalls were found: > > - for detection of charger type by PMIC, bit 6 in the CHGRCTRL1 register > should be set in 0 (and set to 1 for Host mode). Pick up its definition > and logic from from Intel code drop[1]; > > - "#CHARGE ENABLE" signal of external charger (bq25892) in Yoga Book is > connected to one of PMIC outputs controlled by CHGDISCTRL register. > Enable charging at driver initialization. Pick up this from Lenovo's code > drop[2,3]. > > Please keep in mind that I have no docs for Whiskey Cove PMIC, so this patches > are based on some kind of reverse engineering and suppositions, correct me if > this semantic is wrong for common case. > > [1]. https://github.com/01org/ProductionKernelQuilts/uefi/cht-m1stable/patches/0001-power_supply-intel-pmic-ccsm-driver.patch > [2]. https://github.com/jekhor/yogabook-linux-android-kernel/blob/b7aa015ab794b516da7b6cb76e5e2d427e3b8b0c/drivers/power/bq2589x_charger.c#L2257 > [3]. https://github.com/01org/ProductionKernelQuilts/uefi/cht-m1stable/patches/EM-Charger-Disable-battery-charging-in-S3-and-enable.patch > > Yauhen Kharuzhy (2): > extcon-intel-cht-wc: Make charger detection co-existed with OTG host mode > extcon intel-cht-wc: Enable external charger > > drivers/extcon/extcon-intel-cht-wc.c | 71 +++++++++++++++++++++++++++- > 1 file changed, 70 insertions(+), 1 deletion(-) >
-- Best Regards, Chanwoo Choi Samsung Electronics
| |