lkml.org 
[lkml]   [2019]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:perf/core] perf cs-etm: Fix erroneous comment
    Commit-ID:  e4aa592d183228e5fbd3b49a317248c2895d3819
    Gitweb: https://git.kernel.org/tip/e4aa592d183228e5fbd3b49a317248c2895d3819
    Author: Mathieu Poirier <mathieu.poirier@linaro.org>
    AuthorDate: Tue, 12 Feb 2019 10:16:12 -0700
    Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
    CommitDate: Thu, 14 Feb 2019 15:18:07 -0300

    perf cs-etm: Fix erroneous comment

    The comment just before initialising the decoder is plane wrong since it
    is part of the decoding queue setup function and the operation code
    specifically mention that trace data is to be decoded rather than printed
    out.

    This patch simply fix the comment to prevent people from getting really
    confused.

    Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Leo Yan <leo.yan@linaro.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Suzuki K Poulouse <suzuki.poulose@arm.com>
    Cc: linux-arm-kernel@lists.infradead.org
    Link: http://lkml.kernel.org/r/20190212171618.25355-8-mathieu.poirier@linaro.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/util/cs-etm.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c
    index f3a6dfaf3026..4cc9fce97a86 100644
    --- a/tools/perf/util/cs-etm.c
    +++ b/tools/perf/util/cs-etm.c
    @@ -459,7 +459,7 @@ static struct cs_etm_queue *cs_etm__alloc_queue(struct cs_etm_auxtrace *etm,
    if (cs_etm__init_trace_params(t_params, etm))
    goto out_free;

    - /* Set decoder parameters to simply print the trace packets */
    + /* Set decoder parameters to decode trace packets */
    if (cs_etm__init_decoder_params(&d_params, etmq,
    CS_ETM_OPERATION_DECODE))
    goto out_free;
    \
     
     \ /
      Last update: 2019-02-15 10:44    [W:4.074 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site