lkml.org 
[lkml]   [2019]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] exec: load_script: Allow interpreter argument truncation
On Thu, Feb 14, 2019 at 9:59 AM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> On Thu, Feb 14, 2019 at 8:43 AM Kees Cook <keescook@chromium.org> wrote:
> >
> > This documents the parsing steps, and will fail to exec if the string was
> > truncated with neither an end-of-line nor any trailing whitespace.
>
> Is there any reason why we don't just revert 8099b047ecc4 ("exec:
> load_script: don't blindly truncate shebang string").
>
> That revert patch would seem to be much simpler than this rather
> complicated thing.

We certainly can, but we'll still need to fix the "don't exec a
truncated interpreter path" problem (which this fixes).

I'm happy to do it as two steps instead: revert, then a separate fix
to land in the merge window?

--
Kees Cook

\
 
 \ /
  Last update: 2019-02-14 19:11    [W:0.049 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site