lkml.org 
[lkml]   [2019]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] page cache: Store only head pages in i_pages
On Wed 13-02-19 12:17:15, Matthew Wilcox wrote:
> > > - pages[ret] = page;
> > > + pages[ret] = find_subpage(page, xas.xa_index);
> > > if (++ret == nr_pages) {
> > > *start = page->index + 1;
> > > goto out;
> > > }
> >
> > So this subtly changes the behavior because now we will be returning in
> > '*start' a different index. So you should rather use 'pages[ret]->index'
> > instead.
>
> You're right, I made a mistake there. However, seeing this:
> https://lore.kernel.org/lkml/20190110030838.84446-1-yuzhao@google.com/
>
> makes me think that I should be using xa_index + 1 there.

Yeah, you're right. Thanks!

Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR

\
 
 \ /
  Last update: 2019-02-14 17:29    [W:0.069 / U:2.696 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site