lkml.org 
[lkml]   [2019]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 04/65] ASoC: Variable "val" in function rt274_i2c_probe() could be uninitialized
    Date
    From: Yizhuo <yzhai003@ucr.edu>

    [ Upstream commit 8c3590de0a378c2449fc1aec127cc693632458e4 ]

    Inside function rt274_i2c_probe(), if regmap_read() function
    returns -EINVAL, then local variable "val" leaves uninitialized
    but used in if statement. This is potentially unsafe.

    Signed-off-by: Yizhuo <yzhai003@ucr.edu>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/codecs/rt274.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/sound/soc/codecs/rt274.c b/sound/soc/codecs/rt274.c
    index d88e67341083..18a931c25ca5 100644
    --- a/sound/soc/codecs/rt274.c
    +++ b/sound/soc/codecs/rt274.c
    @@ -1126,8 +1126,11 @@ static int rt274_i2c_probe(struct i2c_client *i2c,
    return ret;
    }

    - regmap_read(rt274->regmap,
    + ret = regmap_read(rt274->regmap,
    RT274_GET_PARAM(AC_NODE_ROOT, AC_PAR_VENDOR_ID), &val);
    + if (ret)
    + return ret;
    +
    if (val != RT274_VENDOR_ID) {
    dev_err(&i2c->dev,
    "Device with ID register %#x is not rt274\n", val);
    --
    2.19.1
    \
     
     \ /
      Last update: 2019-02-15 03:36    [W:2.601 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site