lkml.org 
[lkml]   [2019]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] staging: erofs: fix memleak of inode's shared xattr array
From
Date
On 2019/2/14 15:10, Gao Xiang wrote:
>
>
> On 2019/2/14 14:46, Sheng Yong wrote:
>> If it fails to read a shared xattr page, the inode's shared xattr array
>> is not freed. The next time the inode's xattr is accessed, the previously
>> allocated array is leaked.

Nice catch!

>>
>> Signed-off-by: Sheng Yong <shengyong1@huawei.com>
>
> LGTM,
>
> Fixes: b17500a0fdba ("staging: erofs: introduce xattr & acl support")
> Cc: <stable@vger.kernel.org> # 4.19+
> Reviewed-by: Gao Xiang <gaoxiang25@huawei.com>

Reviewed-by: Chao Yu <yuchao0@huawei.com>

Thanks,

>
> [and there is also another race condition in it, but different root cause.
> let me fix it later independently...]
>
> Thanks,
> Gao Xiang
>
> .
>

\
 
 \ /
  Last update: 2019-02-15 03:29    [W:0.036 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site