lkml.org 
[lkml]   [2019]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.4 13/20] scsi: csiostor: fix NULL pointer dereference in csio_vport_set_state()
    Date
    From: Varun Prakash <varun@chelsio.com>

    [ Upstream commit fe35a40e675473eb65f2f5462b82770f324b5689 ]

    Assign fc_vport to ln->fc_vport before calling csio_fcoe_alloc_vnp() to
    avoid a NULL pointer dereference in csio_vport_set_state().

    ln->fc_vport is dereferenced in csio_vport_set_state().

    Signed-off-by: Varun Prakash <varun@chelsio.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/csiostor/csio_attr.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/scsi/csiostor/csio_attr.c b/drivers/scsi/csiostor/csio_attr.c
    index 2d1c4ebd40f9..6587f20cff1a 100644
    --- a/drivers/scsi/csiostor/csio_attr.c
    +++ b/drivers/scsi/csiostor/csio_attr.c
    @@ -582,12 +582,12 @@ csio_vport_create(struct fc_vport *fc_vport, bool disable)
    }

    fc_vport_set_state(fc_vport, FC_VPORT_INITIALIZING);
    + ln->fc_vport = fc_vport;

    if (csio_fcoe_alloc_vnp(hw, ln))
    goto error;

    *(struct csio_lnode **)fc_vport->dd_data = ln;
    - ln->fc_vport = fc_vport;
    if (!fc_vport->node_name)
    fc_vport->node_name = wwn_to_u64(csio_ln_wwnn(ln));
    if (!fc_vport->port_name)
    --
    2.19.1
    \
     
     \ /
      Last update: 2019-02-15 03:19    [W:4.198 / U:1.472 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site