Messages in this thread | | | Date | Thu, 14 Feb 2019 12:57:59 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH v2 1/4] mm: Move recent_rotated pages calculation to shrink_inactive_list() |
| |
On Thu, 14 Feb 2019 13:35:21 +0300 Kirill Tkhai <ktkhai@virtuozzo.com> wrote:
> Currently, struct reclaim_stat::nr_activate is a local variable, > used only in shrink_page_list(). This patch introduces another > local variable pgactivate to use instead of it, and reuses > nr_activate to account number of active pages. > > Note, that we need nr_activate to be an array, since type of page > may change during shrink_page_list() (see ClearPageSwapBacked()).
The patch has nothing to do with the Subject:
reclaim_stat::nr_activate is not a local variable - it is a struct member.
I can kinda see what the patch is doing but the changelog needs more care, please.
| |