Messages in this thread | | | From | David Laight <> | Subject | RE: [PATCH 3/3] leaking_addresses: Expand tilde in output file name | Date | Wed, 13 Feb 2019 15:56:47 +0000 |
| |
From: Tobin C. Harding > Sent: 07 February 2019 22:50 > > Currently if user passes an output file to the script via > --output-raw we do not handle expansion of tilde. > > Use perl function glob() to expand tilde in output file name.
What happens if glob() returns multiple files? I'm guessing that it can...
David
> Signed-off-by: Tobin C. Harding <tobin@kernel.org> > --- > scripts/leaking_addresses.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl > index ef9e5b2a1614..ce545ca3fb70 100755 > --- a/scripts/leaking_addresses.pl > +++ b/scripts/leaking_addresses.pl > @@ -150,7 +150,7 @@ if (!(is_supported_architecture() or $opt_32bit or $page_offset_32bit)) { > } > > if ($output_raw) { > - open my $fh, '>', $output_raw or die "$0: $output_raw: $!\n"; > + open my $fh, '>', glob($output_raw) or die "$0: $output_raw: $!\n"; > select $fh; > } > > -- > 2.20.1
- Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
| |