[lkml]   [2019]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH V19 1/7] i2c: tegra: sort all the include headers alphabetically
13.02.2019 11:35, Wolfram Sang пишет:
>>> "^ Header removal should be mentioned in the commit message, I think."
>>> - Wolfram Sang [0]
>>> Cheers,
>>> Peter
>>> [0]
>> It could make sense to adjust the comment only if there will be
>> anything else worthwhile a new revision, otherwise it is
>> not-so-important.
> Not quite. Addressing review comments and proper commit messages are
> both important. So, it needs to be fixed. Yes, I can fix this small
> issue locally here (and I will do this, so no need to resend), but this
> is ultimately my decision (which you can surely ask for but not
> rely on).
> I'll apply this series later today.

Fixing up minor itches while applying patches is the right approach, thank you!

 \ /
  Last update: 2019-02-13 14:16    [W:0.055 / U:9.844 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site