Messages in this thread | | | From | <> | Subject | Re: [PATCH 07/11] mtd: rawnand: atmel: add sam9x60 nand controller support | Date | Wed, 13 Feb 2019 10:54:12 +0000 |
| |
On 02/13/2019 12:39 PM, Alexandre Belloni wrote: > Hi, > > On 13/02/2019 09:00:05+0000, Tudor.Ambarus@microchip.com wrote: >> - nc->ebi_csa_offs = (uintptr_t)match->data; >> + nc->ebi_csa = (struct atmel_smc_nand_ebi_csa_cfg *)match->data; >> > > This cast is probably not necessary anymore as this cast a pointer to a > pointer. >
it's done to discard the const qualifier from pointer target type. data is of type const void *. nc->ebi_csa was not declared as const because below in the same function we are modifying one of its members:
nc->ebi_csa->offs += 4;
I'll add a comment, thanks!
Cheers, ta
| |