lkml.org 
[lkml]   [2019]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 05/24] misc: vexpress: Off by one in vexpress_syscfg_exec()
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit f8a70d8b889f180e6860cb1f85fed43d37844c5a upstream.

    The > comparison should be >= to prevent reading beyond the end of the
    func->template[] array.

    (The func->template array is allocated in vexpress_syscfg_regmap_init()
    and it has func->num_templates elements.)

    Fixes: 974cc7b93441 ("mfd: vexpress: Define the device as MFD cells")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Acked-by: Sudeep Holla <sudeep.holla@arm.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/misc/vexpress-syscfg.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/misc/vexpress-syscfg.c
    +++ b/drivers/misc/vexpress-syscfg.c
    @@ -61,7 +61,7 @@ static int vexpress_syscfg_exec(struct v
    int tries;
    long timeout;

    - if (WARN_ON(index > func->num_templates))
    + if (WARN_ON(index >= func->num_templates))
    return -EINVAL;

    command = readl(syscfg->base + SYS_CFGCTRL);

    \
     
     \ /
      Last update: 2019-02-13 19:56    [W:4.578 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site