lkml.org 
[lkml]   [2019]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] elf: use list_for_each_entry()
Hi Alexey,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.0-rc4]
[cannot apply to next-20190212]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Alexey-Dobriyan/elf-don-t-be-afraid-of-overflow/20190205-225931
config: nds32-defconfig (attached as .config)
compiler: nds32le-linux-gcc (GCC) 6.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=6.4.0 make.cross ARCH=nds32

All errors (new ones prefixed by >>):

fs/binfmt_elf.c: In function 'write_note_info':
>> fs/binfmt_elf.c:2124:19: error: 'tmp' undeclared (first use in this function)
for (i = 0; i < tmp->num_notes; i++)
^~~
fs/binfmt_elf.c:2124:19: note: each undeclared identifier is reported only once for each function it appears in

vim +/tmp +2124 fs/binfmt_elf.c

3aba481f Roland McGrath 2008-01-30 2111
3aba481f Roland McGrath 2008-01-30 2112 static int write_note_info(struct elf_note_info *info,
ecc8c772 Al Viro 2013-10-05 2113 struct coredump_params *cprm)
3aba481f Roland McGrath 2008-01-30 2114 {
1e0d184d Alexey Dobriyan 2019-02-04 2115 struct elf_thread_status *ets;
3aba481f Roland McGrath 2008-01-30 2116 int i;
3aba481f Roland McGrath 2008-01-30 2117
3aba481f Roland McGrath 2008-01-30 2118 for (i = 0; i < info->numnote; i++)
ecc8c772 Al Viro 2013-10-05 2119 if (!writenote(info->notes + i, cprm))
3aba481f Roland McGrath 2008-01-30 2120 return 0;
3aba481f Roland McGrath 2008-01-30 2121
3aba481f Roland McGrath 2008-01-30 2122 /* write out the thread status notes section */
1e0d184d Alexey Dobriyan 2019-02-04 2123 list_for_each_entry(ets, &info->thread_list, list) {
3aba481f Roland McGrath 2008-01-30 @2124 for (i = 0; i < tmp->num_notes; i++)
ecc8c772 Al Viro 2013-10-05 2125 if (!writenote(&tmp->notes[i], cprm))
3aba481f Roland McGrath 2008-01-30 2126 return 0;
3aba481f Roland McGrath 2008-01-30 2127 }
3aba481f Roland McGrath 2008-01-30 2128
3aba481f Roland McGrath 2008-01-30 2129 return 1;
3aba481f Roland McGrath 2008-01-30 2130 }
3aba481f Roland McGrath 2008-01-30 2131

:::::: The code at line 2124 was first introduced by commit
:::::: 3aba481fc94d83ff630d4b7cd2f7447010c4c6df elf core dump: notes reorg

:::::: TO: Roland McGrath <roland@redhat.com>
:::::: CC: Ingo Molnar <mingo@elte.hu>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2019-02-12 16:50    [W:0.073 / U:0.936 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site