lkml.org 
[lkml]   [2019]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [linux-sunxi] [PATCH v3 2/2] media: cedrus: Add H264 decoding support
Hi,

On Mon, Feb 11, 2019 at 08:21:31PM +0100, Jernej Škrabec wrote:
> > + reg = 0;
> > + /*
> > + * FIXME: This bit tells the video engine to use the default
> > + * quantization matrices. This will obviously need to be
> > + * changed to support the profiles supporting custom
> > + * quantization matrices.
> > + */
> > + reg |= VE_H264_SHS_QP_SCALING_MATRIX_DEFAULT;
>
> This flag should not be needed anymore. From what I see, you correctly set
> scaling matrix every time.

The scaling matrix control is optional, so I guess we should protect
that by a check on whether that control has been set or not. What do
you think?

Thanks!
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-02-12 11:43    [W:0.045 / U:0.240 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site