lkml.org 
[lkml]   [2019]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 5/5] riscv: use for_each_of_cpu_node iterator
From
Date
On 2/12/19 12:26 AM, Johan Hovold wrote:
> On Mon, Feb 11, 2019 at 11:13:39PM -0800, Christoph Hellwig wrote:
>> On Fri, Jan 18, 2019 at 03:03:08PM +0100, Johan Hovold wrote:
>>> Use the new for_each_of_cpu_node() helper to iterate over cpu nodes
>>> instead of open coding. Note that this will allow matching also on the
>>> node name instead of the (for FDT) deprecated device_type property.
>>>
>>> Signed-off-by: Johan Hovold <johan@kernel.org>
>>
>> I think this is going to conflict with the ELF caps changes from
>> Atish. Maybe the riscv_fill_hwcap hunk should be included in his
>> patch?
>
> Since that patch had some issues (e.g. the node reference underflow) it
> may be better to rebase it on top of this series. The changes are
> otherwise distinct after all.
>

I have fixed the node reference underflow issue and made some more
changes based on comments.

Some other patches(1,3,4,5) in this series may conflict with my series
as well. I can rebase my series on top of yours and send it as one
series if that's okay with you and Palmer.

Regards,
Atish
>> Otherwise looks good:
>>
>> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> Thanks for reviewing!
>
> Johan
>

\
 
 \ /
  Last update: 2019-02-12 09:48    [W:0.043 / U:30.328 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site