lkml.org 
[lkml]   [2019]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] USB: musb: mark expected switch fall-through
Hi Greg,

On Tue, Feb 12, 2019 at 01:23:57PM -0600, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/usb/musb/musb_host.c: In function ‘musb_advance_schedule’:
> drivers/usb/musb/musb_host.c:374:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (qh->mux == 1) {
> ^
> drivers/usb/musb/musb_host.c:383:3: note: here
> case USB_ENDPOINT_XFER_ISOC:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> Notice that, in this particular case, the code comment is modified
> in accordance with what GCC is expecting to find.
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

I've closed my musb tree for v5.1-rc1, if you want to directly pick this
patch, here is my Acked-by, or I will take it for v5.2-rc1.

Acked-by: Bin Liu <b-liu@ti.com>

> ---
> drivers/usb/musb/musb_host.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
> index b59ce9ad14ce..0566d5b6252e 100644
> --- a/drivers/usb/musb/musb_host.c
> +++ b/drivers/usb/musb/musb_host.c
> @@ -378,7 +378,7 @@ static void musb_advance_schedule(struct musb *musb, struct urb *urb,
> qh = first_qh(head);
> break;
> }
> - /* else: fall through */
> + /* fall through */
>
> case USB_ENDPOINT_XFER_ISOC:
> case USB_ENDPOINT_XFER_INT:
> --
> 2.20.1

Regards,
-Bin.

\
 
 \ /
  Last update: 2019-02-12 20:48    [W:0.052 / U:2.648 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site