lkml.org 
[lkml]   [2019]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 047/137] sata_rcar: fix deferred probing
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    [ Upstream commit 9f83cfdb1ace3ef268ecc6fda50058d2ec37d603 ]

    The driver overrides the error codes returned by platform_get_irq() to
    -EINVAL, so if it returns -EPROBE_DEFER, the driver would fail the probe
    permanently instead of the deferred probing. Switch to propagating the
    error code upstream, still checking/overriding IRQ0 as libata regards it
    as "no IRQ" (thus polling) anyway...

    Fixes: 9ec36cafe43b ("of/irq: do irq resolution in platform_get_irq")
    Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
    Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
    Signed-off-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/ata/sata_rcar.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/ata/sata_rcar.c b/drivers/ata/sata_rcar.c
    index e83a3d3421b9..07e146b772ea 100644
    --- a/drivers/ata/sata_rcar.c
    +++ b/drivers/ata/sata_rcar.c
    @@ -872,7 +872,9 @@ static int sata_rcar_probe(struct platform_device *pdev)
    int ret = 0;

    irq = platform_get_irq(pdev, 0);
    - if (irq <= 0)
    + if (irq < 0)
    + return irq;
    + if (!irq)
    return -EINVAL;

    priv = devm_kzalloc(&pdev->dev, sizeof(struct sata_rcar_priv),
    --
    2.19.1


    \
     
     \ /
      Last update: 2019-02-11 16:16    [W:4.843 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site