lkml.org 
[lkml]   [2019]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 7/9] usb: typec: Find the ports by also matching against the device node
Hi Andy,

On Thu, Jan 31, 2019 at 03:35:37PM +0200, Heikki Krogerus wrote:
> On Wed, Jan 30, 2019 at 06:51:56PM +0200, Andy Shevchenko wrote:
> > On Wed, Jan 30, 2019 at 6:03 PM Heikki Krogerus
> > <heikki.krogerus@linux.intel.com> wrote:
> > >
> > > When the connections are defined in firmware, struct
> > > device_connection will have the fwnode member pointing to
> > > the device node (struct fwnode_handle) of the requested
> > > device, and the endpoint will not be used at all in that
> > > case.
> >
> > > + /*
> > > + * FIXME: Check does the fwnode supports the requested SVID. If it does
> > > + * we need to return ERR_PTR(-PROBE_DEFER) when there is no device.
> > > + */
> > > + if (con->fwnode)
> > > + return class_find_device(typec_class, NULL, con->fwnode,
> > > + typec_port_fwnode_match);
> > > +
> > > + dev = class_find_device(typec_class, NULL, con->endpoint[ep],
> > > + typec_port_name_match);
> > > +
> > > + return dev ? dev : ERR_PTR(-EPROBE_DEFER);
> >
> > Just to be clear, this one takes a reference on dev. Is it taken into account?
>
> Yes. That is what we want it to do.

Gentle ping. Is the series OK?

thanks,

--
heikki

\
 
 \ /
  Last update: 2019-02-11 09:39    [W:0.038 / U:5.492 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site