Messages in this thread | | | From | Lukas Bulwahn <> | Date | Mon, 11 Feb 2019 16:14:12 +0100 (CET) | Subject | Re: [PATCH] MAINTAINERS: use tab instead of spaces |
| |
iOn Sun, 10 Feb 2019, Joe Perches wrote:
> On Sun, 2019-02-10 at 19:10 +0100, Lukas Bulwahn wrote: > > Mimi Zohar used spaces instead of a tab when adding Jarkko Sakkinen as > > further maintainer to the KEYS-TRUSTED section entry. So, we rectify this > > with this commit. > > > > The issue was detected when writing a script that parses MAINTAINERS. > > checkpatch already does that btw:
Good to know.
> > $ ./scripts/checkpatch.pl -f MAINTAINERS > WARNING: MAINTAINERS entries use one tab after TYPE: > #8408: FILE: MAINTAINERS:8408: > +M: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > > WARNING: MAINTAINERS entries use one tab after TYPE: > #12607: FILE: MAINTAINERS:12607: > +M: Ilia Lin <ilia.lin@gmail.com> > > WARNING: MAINTAINERS entries use one tab after TYPE: > #12608: FILE: MAINTAINERS:12608: > +L: linux-pm@vger.kernel.org > > WARNING: MAINTAINERS entries use one tab after TYPE: > #12609: FILE: MAINTAINERS:12609: > +S: Maintained > > WARNING: MAINTAINERS entries use one tab after TYPE: > #12610: FILE: MAINTAINERS:12610: > +F: Documentation/devicetree/bindings/opp/kryo-cpufreq.txt > > WARNING: MAINTAINERS entries use one tab after TYPE: > #12611: FILE: MAINTAINERS:12611: > +F: drivers/cpufreq/qcom-cpufreq-kryo.c > > total: 0 errors, 6 warnings, 16993 lines checked > > NOTE: For some of the reported defects, checkpatch may be able to > mechanically convert to the typical style using --fix or --fix-inplace >
On next-20190211, the checkpatch issues in line 12607 to 12611 are not reported anymore, as I already fixed them in commit 70e6e7d92bca ("MAINTAINERS: use common indentation").
So, the issue addressed here and in the later follow-up patch is the only style-related issue in MAINTAINERS.
After that, everything in MAINTAINERS is stylistically clean.
Lukas
| |