lkml.org 
[lkml]   [2019]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] parport: daisy: use new parport device model
On Sat, Feb 09, 2019 at 08:59:06PM +0000, Sudip Mukherjee wrote:
> - return bus_register(&parport_bus_type);
> + int retval;
> +
> + retval = bus_register(&parport_bus_type);
> + if (retval)
> + return retval;
> +#ifdef CONFIG_PARPORT_1284
> + daisy_drv_init();
> +#endif

Shouldn't you hide these #ifdef lines in the .h file instead of putting
them in the .c file?

thanks,

greg k-h

\
 
 \ /
  Last update: 2019-02-11 09:38    [W:0.031 / U:3.384 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site