lkml.org 
[lkml]   [2019]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 059/313] dmaengine: xilinx_dma: Remove __aligned attribute on zynqmp_dma_desc_ll
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    [ Upstream commit aeaebcc17cdf37065d2693865eeb1ff1c7dc5bf3 ]

    Clang warns:

    drivers/dma/xilinx/zynqmp_dma.c:166:4: warning: attribute 'aligned' is
    ignored, place it after "struct" to apply attribute to type declaration
    [-Wignored-attributes]
    }; __aligned(64)
    ^
    ./include/linux/compiler_types.h:200:38: note: expanded from macro
    '__aligned'
    ^
    1 warning generated.

    As Nick pointed out in the previous version of this patch, the author
    likely intended for this struct to be 8-byte (64-bit) aligned, not
    64-byte, which is the default. Remove the hanging __aligned attribute.

    Fixes: b0cc417c1637 ("dmaengine: Add Xilinx zynqmp dma engine driver support")
    Reported-by: Nick Desaulniers <ndesaulniers@google.com>
    Suggested-by: Nick Desaulniers <ndesaulniers@google.com>
    Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
    Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/dma/xilinx/zynqmp_dma.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c
    index c74a88b65039..73de6a6179fc 100644
    --- a/drivers/dma/xilinx/zynqmp_dma.c
    +++ b/drivers/dma/xilinx/zynqmp_dma.c
    @@ -163,7 +163,7 @@ struct zynqmp_dma_desc_ll {
    u32 ctrl;
    u64 nxtdscraddr;
    u64 rsvd;
    -}; __aligned(64)
    +};

    /**
    * struct zynqmp_dma_desc_sw - Per Transaction structure
    --
    2.19.1


    \
     
     \ /
      Last update: 2019-02-11 15:43    [W:3.125 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site