[lkml]   [2019]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 4.20 310/352] net: dsa: b53: Fix for failure when irq is not defined in dt
4.20-stable review patch.  If anyone has any objections, please let me know.


From: Arun Parameswaran <>

[ Upstream commit 39841cc1cbb69344539c98a1fa9d858ed124c7ba ]

Fixes the issues with non BCM58XX chips in the b53 driver
failing, when the irq is not specified in the device tree.

Removed the check for BCM58XX in b53_srab_prepare_irq(),
so the 'port->irq' will be set to '-EXIO' if the irq is not
specified in the device tree.

Fixes: 16994374a6fc ("net: dsa: b53: Make SRAB driver manage port interrupts")
Fixes: b2ddc48a81b5 ("net: dsa: b53: Do not fail when IRQ are not initialized")
Signed-off-by: Arun Parameswaran <>
Reviewed-by: Florian Fainelli <>
Signed-off-by: David S. Miller <>
Signed-off-by: Greg Kroah-Hartman <>
drivers/net/dsa/b53/b53_srab.c | 3 ---
1 file changed, 3 deletions(-)

--- a/drivers/net/dsa/b53/b53_srab.c
+++ b/drivers/net/dsa/b53/b53_srab.c
@@ -511,9 +511,6 @@ static void b53_srab_prepare_irq(struct
/* Clear all pending interrupts */
writel(0xffffffff, priv->regs + B53_SRAB_INTR);

- if (dev->pdata && dev->pdata->chip_id != BCM58XX_DEVICE_ID)
- return;
for (i = 0; i < B53_N_PORTS; i++) {
port = &priv->port_intrs[i];

 \ /
  Last update: 2019-02-11 15:37    [W:0.872 / U:11.692 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site