Messages in this thread | | | From | Felipe Balbi <> | Subject | RE: [PATCH v3 2/6] usb:common Separated decoding functions from dwc3 driver. | Date | Mon, 11 Feb 2019 15:20:04 +0200 |
| |
Hi,
Pawel Laszczak <pawell@cadence.com> writes: >>>> +/** >>>> + * usb_decode_ctrl - Returns human readable representation of control request. >>>> + * @str: buffer to return a human-readable representation of control request. >>>> + * This buffer should have about 200 bytes. >>> >>> "about 200 bytes" is not very specific. >>> >>> Pass in the length so we know we don't overflow it. >> >>agree. > I also agree and I will add such parameter.
https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git/commit/?h=next&id=7790b3556fccc555ae422f1576e97bf34c8ab8b6
-- balbi [unhandled content-type:application/pgp-signature]
| |