lkml.org 
[lkml]   [2019]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RESEND PATCH v2 28/33] ARM: davinci: cp-intc: unify error handling
From
Date
On 11/02/2019 12:26, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> Use WARN_ON() on eny error in cp-intc initialization and drop all
> custom error messages.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Reviewed-by: David Lechner <david@lechnology.com>
> ---
> arch/arm/mach-davinci/cp_intc.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/cp_intc.c b/arch/arm/mach-davinci/cp_intc.c
> index f3787ae4cdbd..c1efb9390655 100644
> --- a/arch/arm/mach-davinci/cp_intc.c
> +++ b/arch/arm/mach-davinci/cp_intc.c
> @@ -200,20 +200,16 @@ davinci_cp_intc_do_init(const struct davinci_cp_intc_config *config,
> DAVINCI_CP_INTC_CHAN_MAP(offset));
>
> irq_base = irq_alloc_descs(-1, 0, config->num_irqs, 0);
> - if (irq_base < 0) {
> - pr_warn("Couldn't allocate IRQ numbers\n");
> - irq_base = 0;
> - }
> + if (WARN_ON(irq_base < 0))
> + return irq_base;
>
> /* create a legacy host */
> davinci_cp_intc_irq_domain = irq_domain_add_legacy(
> node, config->num_irqs, irq_base, 0,
> &davinci_cp_intc_irq_domain_ops, NULL);
>
> - if (!davinci_cp_intc_irq_domain) {
> - pr_err("cp_intc: failed to allocate irq host!\n");
> + if (WARN_ON(!davinci_cp_intc_irq_domain))
> return -EINVAL;
> - }
>
> set_handle_irq(davinci_cp_intc_handle_irq);
>
>

I'm sorry, but how is turning an explicit message into a long stack
trace really useful?

M.
--
Jazz is not dead. It just smells funny...

\
 
 \ /
  Last update: 2019-02-11 14:09    [W:0.142 / U:6.464 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site