lkml.org 
[lkml]   [2019]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] fs: Allow opening only regular files during execve().
From
Date
Andrew Morton wrote:
> > --- a/fs/open.c
> > +++ b/fs/open.c
> > @@ -733,6 +733,12 @@ static int do_dentry_open(struct file *f,
> > return 0;
> > }
> >
> > + /* Any file opened for execve()/uselib() has to be a regular file. */
> > + if (unlikely(f->f_flags & FMODE_EXEC && !S_ISREG(inode->i_mode))) {
> > + error = -EACCES;
> > + goto cleanup_file;
> > + }
> > +
> > if (f->f_mode & FMODE_WRITE && !special_file(inode->i_mode)) {
> > error = get_write_access(inode);
> > if (unlikely(error))
>
> This change sounds legitimate for various other reasons, but it's a
> concern that this locking error occurred in the first place. There's a
> problem somewhere (probably the pipe code) which may bite us in other
> situations, even with this workaround in place.
>
>

This error seems to be introduced in 2.6.39-rc1 by commit a9712bc12c40c172
("deal with races in /proc/*/{syscall,stack,personality}"). Thus, I don't
think that this patch will bite us in other situations.
Al, how do you want to handle this?

\
 
 \ /
  Last update: 2019-02-12 03:02    [W:0.049 / U:5.512 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site