lkml.org 
[lkml]   [2019]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1 03/16] powerpc/32: move LOAD_MSR_KERNEL() into head_32.h and use it
From
Date


Le 11/02/2019 à 01:21, Benjamin Herrenschmidt a écrit :
> On Fri, 2019-02-08 at 12:52 +0000, Christophe Leroy wrote:
>> /*
>> + * MSR_KERNEL is > 0x8000 on 4xx/Book-E since it include MSR_CE.
>> + */
>> +.macro __LOAD_MSR_KERNEL r, x
>> +.if \x >= 0x8000
>> + lis \r, (\x)@h
>> + ori \r, \r, (\x)@l
>> +.else
>> + li \r, (\x)
>> +.endif
>> +.endm
>> +#define LOAD_MSR_KERNEL(r, x) __LOAD_MSR_KERNEL r, x
>> +
>
> You changed the limit from >= 0x10000 to >= 0x8000 without a
> corresponding explanation as to why...

Yes, the existing LOAD_MSR_KERNEL() was buggy because 'li' takes a
signed u16, ie between -0x8000 and 0x7999.

By chance it was working because until now nobody was trying to set
MSR_KERNEL | MSR_EE.

Christophe

\
 
 \ /
  Last update: 2019-02-11 07:27    [W:0.069 / U:3.816 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site