lkml.org 
[lkml]   [2019]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [RFC v1] tlv320aic32x4: delay i2c access by 1 ms after hardware reset
Hello Mark,

On Mon, 11 Feb 2019 15:04:25 +0000, Mark Brown <broonie@kernel.org> wrote:

> On Sun, Feb 10, 2019 at 04:45:19PM +0100, Peter Seiderer wrote:
>
> > @@ -972,6 +972,8 @@ static int aic32x4_component_probe(struct snd_soc_component *component)
> > gpio_set_value(aic32x4->rstn_gpio, 1);
> > }
> >
> > + mdelay(1);
> > +
>
> Perhaps only do this if we toggled the GPIO? If the device wasn't in
> reset then there's no need to wait.

You are absolutely right with this, will re-spin the patch with
the suggested change, thanks for review...

Regards,
Peter

\
 
 \ /
  Last update: 2019-02-11 22:04    [W:0.032 / U:6.864 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site