lkml.org 
[lkml]   [2019]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] vmw_balloon: release lock on error in vmballoon_reset()
Date
> On Feb 11, 2019, at 10:45 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> We added some locking to this function but forgot to drop the lock on
> these two error paths. This bug would lead to an immediate deadlock.
>
> Fixes: c7b3690fb152 ("vmw_balloon: stats rework")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Cc: stable@vger.kernel.org
Reviewed-by: Nadav Amit <namit@vmware.com>

--

Yes, I screwed up. Thanks for catching it!

I’ll go to check why my error injection tests didn’t catch it.

\
 
 \ /
  Last update: 2019-02-11 20:13    [W:0.033 / U:1.340 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site