Messages in this thread | | | From | Nadav Amit <> | Subject | Re: [PATCH] vmw_balloon: release lock on error in vmballoon_reset() | Date | Mon, 11 Feb 2019 19:12:40 +0000 |
| |
> On Feb 11, 2019, at 10:45 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > > We added some locking to this function but forgot to drop the lock on > these two error paths. This bug would lead to an immediate deadlock. > > Fixes: c7b3690fb152 ("vmw_balloon: stats rework") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: stable@vger.kernel.org Reviewed-by: Nadav Amit <namit@vmware.com>
--
Yes, I screwed up. Thanks for catching it!
I’ll go to check why my error injection tests didn’t catch it.
| |