lkml.org 
[lkml]   [2019]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 5/5] ARM: warn if divided syntax assembler is used
On Sat, Feb 9, 2019 at 3:09 PM Stefan Agner <stefan@agner.ch> wrote:
>
> Remove the -mno-warn-deprecated assembler flag to make sure the GNU
> assembler warns in case non-unified syntax is used.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> Changes in v2:
> - Remove AFLAGS_NOWARN from CFLAGS_ISA

Thanks for making this requested change.
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>

>
> arch/arm/Makefile | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> index a0d08a3c9d33..9561325c5201 100644
> --- a/arch/arm/Makefile
> +++ b/arch/arm/Makefile
> @@ -112,19 +112,16 @@ ifeq ($(CONFIG_ARM_UNWIND),y)
> CFLAGS_ABI +=-funwind-tables
> endif
>
> -# Accept old syntax despite ".syntax unified"
> -AFLAGS_NOWARN :=$(call as-option,-Wa$(comma)-mno-warn-deprecated,-Wa$(comma)-W)
> -
> ifeq ($(CONFIG_THUMB2_KERNEL),y)
> AFLAGS_AUTOIT :=$(call as-option,-Wa$(comma)-mimplicit-it=always,-Wa$(comma)-mauto-it)
> -CFLAGS_ISA :=-mthumb $(AFLAGS_AUTOIT) $(AFLAGS_NOWARN)
> +CFLAGS_ISA :=-mthumb $(AFLAGS_AUTOIT)
> AFLAGS_ISA :=$(CFLAGS_ISA) -Wa$(comma)-mthumb
> # Work around buggy relocation from gas if requested:
> ifeq ($(CONFIG_THUMB2_AVOID_R_ARM_THM_JUMP11),y)
> KBUILD_CFLAGS_MODULE +=-fno-optimize-sibling-calls
> endif
> else
> -CFLAGS_ISA :=$(call cc-option,-marm,) $(AFLAGS_NOWARN)
> +CFLAGS_ISA :=$(call cc-option,-marm,)
> AFLAGS_ISA :=$(CFLAGS_ISA)
> endif
>
> --
> 2.20.1
>


--
Thanks,
~Nick Desaulniers

\
 
 \ /
  Last update: 2019-02-11 19:03    [W:0.111 / U:0.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site