lkml.org 
[lkml]   [2019]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-next: Fixes tag needs some work in the driver-core tree
On Mon, Feb 11, 2019 at 08:44:02AM +0100, Greg KH wrote:
> On Mon, Feb 11, 2019 at 07:40:52AM +1100, Stephen Rothwell wrote:
> > Hi Greg,
> >
> > In commit
> >
> > 344c0152d878 ("selftests: firmware: fix verify_reqs() return value")
> >
> > Fixes tag
> >
> > Fixes: a6a9be9270c87 ("selftests: firmware: return Kselftest Skip code for for skipped tests")
> >
> > has these problem(s):
> >
> > - Subject does not match target commit subject
>
> I don't understand, what is wrong with the fixes: tag here?
>
> $ git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n" a6a9be9270c87
> a6a9be9270c8 ("selftests: firmware: return Kselftest Skip code for skipped tests")
>
> How does that not match up?
>
> Ah, an extra "for" in there. Luis, you need to fix up your scripts, and
> not be forced to manually type in those lines :)

Will do.

Luis

\
 
 \ /
  Last update: 2019-02-11 18:11    [W:0.037 / U:3.356 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site