lkml.org 
[lkml]   [2019]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.20 271/352] gdrom: fix a memory leak bug
    Date
    4.20-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    [ Upstream commit 093c48213ee37c3c3ff1cf5ac1aa2a9d8bc66017 ]

    In probe_gdrom(), the buffer pointed by 'gd.cd_info' is allocated through
    kzalloc() and is used to hold the information of the gdrom device. To
    register and unregister the device, the pointer 'gd.cd_info' is passed to
    the functions register_cdrom() and unregister_cdrom(), respectively.
    However, this buffer is not freed after it is used, which can cause a
    memory leak bug.

    This patch simply frees the buffer 'gd.cd_info' in exit_gdrom() to fix the
    above issue.

    Signed-off-by: Wenwen Wang <wang6495@umn.edu>
    Signed-off-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/cdrom/gdrom.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/cdrom/gdrom.c b/drivers/cdrom/gdrom.c
    index a5b8afe3609c..f8b7345fe1cb 100644
    --- a/drivers/cdrom/gdrom.c
    +++ b/drivers/cdrom/gdrom.c
    @@ -873,6 +873,7 @@ static void __exit exit_gdrom(void)
    platform_device_unregister(pd);
    platform_driver_unregister(&gdrom_driver);
    kfree(gd.toc);
    + kfree(gd.cd_info);
    }

    module_init(init_gdrom);
    --
    2.19.1


    \
     
     \ /
      Last update: 2019-02-11 16:57    [W:4.260 / U:0.248 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site