lkml.org 
[lkml]   [2019]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 165/313] tools/power/x86/intel_pstate_tracer: Fix non root execution for post processing a trace file
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    [ Upstream commit 663546903c835fe46308b1b1e53d32d1f2b33da9 ]

    This script is supposed to be allowed to run with regular user
    privileges if a previously captured trace is being post processed.

    Commit fbe313884d7d (tools/power/x86/intel_pstate_tracer: Free the
    trace buffer memory) introduced a bug that breaks that option.

    Commit 35459105deb2 (tools/power/x86/intel_pstate_tracer: Add
    optional setting of trace buffer memory allocation) moved the code
    but kept the bug.

    This patch fixes the issue.

    Fixes: 35459105deb2 (tools/power/x86/intel_pstate_tracer: Add optional ...)
    Signed-off-by: Doug Smythies <dsmythies@telus.net>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
    index 84e2b648e622..2fa3c5757bcb 100755
    --- a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
    +++ b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
    @@ -585,9 +585,9 @@ current_max_cpu = 0

    read_trace_data(filename)

    -clear_trace_file()
    -# Free the memory
    if interval:
    + clear_trace_file()
    + # Free the memory
    free_trace_buffer()

    if graph_data_present == False:
    --
    2.19.1


    \
     
     \ /
      Last update: 2019-02-11 16:43    [W:4.644 / U:0.620 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site