lkml.org 
[lkml]   [2019]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 06/22] ASoC: samsung: i2s: Restore support for the secondary PCM
From
Date
On 2/11/19 14:41, Krzysztof Kozlowski wrote:
>> @@ -1469,12 +1506,16 @@ static int samsung_i2s_remove(struct platform_device *pdev)
>> struct samsung_i2s_priv *priv = dev_get_drvdata(&pdev->dev);
>> struct i2s_dai *pri_dai = samsung_i2s_get_pri_dai(&pdev->dev);
>>
>> + if (!priv)

> This is not obvious. Maybe comment that it is secondary device remove()?

Sure, I will a comment here, I was considering it earlier but somehow it got missed.

>> @@ -1573,6 +1614,9 @@ static const struct platform_device_id samsung_i2s_driver_ids[] = {
>> .name = "samsung-i2s",
>> .driver_data = (kernel_ulong_t)&i2sv3_dai_type,
>> },
>> + {

> Nit - squash with previous line.

Will change it.


--
Thanks,
Sylwester

\
 
 \ /
  Last update: 2019-02-11 16:38    [W:0.056 / U:6.944 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site