lkml.org 
[lkml]   [2019]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 127/205] ACPI/APEI: Clear GHES block_status before panic()
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    [ Upstream commit 98cff8b23ed1c763a029ee81ea300df0d153d07d ]

    In __ghes_panic() clear the block status in the APEI generic
    error status block for that generic hardware error source before
    calling panic() to prevent a second panic() in the crash kernel
    for exactly the same fatal error.

    Otherwise ghes_probe(), running in the crash kernel, would see
    an unhandled error in the APEI generic error status block and
    panic again, thereby precluding any crash dump.

    Signed-off-by: Lenny Szubowicz <lszubowi@redhat.com>
    Signed-off-by: David Arcari <darcari@redhat.com>
    Tested-by: Tyler Baicar <baicar.tyler@gmail.com>
    Acked-by: Borislav Petkov <bp@suse.de>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/acpi/apei/ghes.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
    index f14695e744d0..5889f6407fea 100644
    --- a/drivers/acpi/apei/ghes.c
    +++ b/drivers/acpi/apei/ghes.c
    @@ -675,6 +675,8 @@ static void __ghes_panic(struct ghes *ghes)
    {
    __ghes_print_estatus(KERN_EMERG, ghes->generic, ghes->estatus);

    + ghes_clear_estatus(ghes);
    +
    /* reboot to log the error! */
    if (!panic_timeout)
    panic_timeout = ghes_panic_timeout;
    --
    2.19.1


    \
     
     \ /
      Last update: 2019-02-11 16:27    [W:4.942 / U:0.224 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site