lkml.org 
[lkml]   [2019]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH net-next v2 00/16] net: Remove switchdev_ops
    Date
    Le 2/10/19 à 9:50 AM, Florian Fainelli a écrit :
    > Hi all,
    >
    > This patch series finishes by the removal of switchdev_ops. To get there
    > we need to do a few things:
    >
    > - get rid of the one and only call to switchdev_port_attr_get() which is
    > used to fetch the device's bridge port flags capabilities, instead we
    > can just check what flags are being programmed during the prepare
    > phase
    >
    > - once we get rid of getting switchdev port attributes we convert the
    > setting of such attributes using a blocking notifier
    >
    > And then remove switchdev_ops completely.
    >
    > Please review and let me know what you think!

    I am going to submit a v3 which moves the port_attr_{get,set} to a
    switchdev notifier, but does not yet get rid of
    switchdev_port_attr_get() entirely since there is not a clear path yet
    to split the setting between non-sleeping and sleeping context.

    >
    > Changes in v2:
    > - fixed bisectability issues in patch #15
    > - added Acked-by from Jiri where necessary
    > - fixed a few minor issues according to Jiri's feedback:
    > - rename port_attr_event -> port_attr_set_event
    > - moved SWITCHDEV_PORT_ATTR_SET closer to other blocking events
    >
    > Florian Fainelli (16):
    > Documentation: networking: switchdev: Update port parent ID section
    > mlxsw: spectrum: Check bridge flags during prepare phase
    > staging: fsl-dpaa2: ethsw: Check bridge port flags during set
    > net: dsa: Add setter for SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS
    > rocker: Check bridge flags during prepare phase
    > net: bridge: Stop calling switchdev_port_attr_get()
    > net: Remove SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT
    > net: Get rid of switchdev_port_attr_get()
    > switchdev: Add SWITCHDEV_PORT_ATTR_SET
    > rocker: Handle SWITCHDEV_PORT_ATTR_SET
    > net: dsa: Handle SWITCHDEV_PORT_ATTR_SET
    > mlxsw: spectrum_switchdev: Handle SWITCHDEV_PORT_ATTR_SET
    > net: mscc: ocelot: Handle SWITCHDEV_PORT_ATTR_SET
    > staging: fsl-dpaa2: ethsw: Handle SWITCHDEV_PORT_ATTR_SET
    > net: switchdev: Replace port attr set SDO with a notification
    > net: Remove switchdev_ops
    >
    > Documentation/networking/switchdev.txt | 15 ++-
    > .../net/ethernet/mellanox/mlxsw/spectrum.c | 12 ---
    > .../net/ethernet/mellanox/mlxsw/spectrum.h | 2 -
    > .../mellanox/mlxsw/spectrum_switchdev.c | 69 ++++----------
    > drivers/net/ethernet/mscc/ocelot.c | 21 +++-
    > drivers/net/ethernet/rocker/rocker_main.c | 95 ++++++++-----------
    > drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 48 ++++------
    > include/linux/netdevice.h | 3 -
    > include/net/switchdev.h | 36 ++-----
    > net/bridge/br_switchdev.c | 20 +---
    > net/dsa/dsa_priv.h | 3 +
    > net/dsa/port.c | 10 ++
    > net/dsa/slave.c | 40 ++++----
    > net/switchdev/switchdev.c | 92 +++++-------------
    > 14 files changed, 170 insertions(+), 296 deletions(-)
    >


    --
    Florian

    \
     
     \ /
      Last update: 2019-02-10 21:45    [W:2.668 / U:0.528 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site