lkml.org 
[lkml]   [2019]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/9] iommu/vt-d: Allow interrupts from the entire bus for aliased devices
On Thu, Jan 31, 2019 at 11:56:48AM -0700, Logan Gunthorpe wrote:
> @@ -394,6 +402,10 @@ static int set_msi_sid(struct irte *irte, struct pci_dev *dev)
> set_irte_sid(irte, SVT_VERIFY_BUS, SQ_ALL_16,
> PCI_DEVID(PCI_BUS_NUM(data.alias),
> dev->bus->number));
> + else if (data.count >= 2 && data.busmatch_count == data.count)
> + set_irte_sid(irte, SVT_VERIFY_BUS, SQ_ALL_16,
> + PCI_DEVID(dev->bus->number,
> + dev->bus->number));

The dev->bus->number argument for the devfn parameter of PCI_DEVID is
not needed, right?

Also, this requires at least a comment to document that special case.


Joerg

\
 
 \ /
  Last update: 2019-02-01 17:44    [W:0.127 / U:6.848 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site