Messages in this thread | | | Date | Fri, 1 Feb 2019 17:16:38 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH 03/19] dma-iommu: don't use a scatterlist in iommu_dma_alloc |
| |
On Fri, Feb 01, 2019 at 03:24:45PM +0000, Robin Murphy wrote: > On 14/01/2019 09:41, Christoph Hellwig wrote: >> Directly iterating over the pages makes the code a bit simpler and >> prepares for the following changes. > > It also defeats the whole purpose of __iommu_dma_alloc_pages(), so I'm not > really buying the simplification angle - you've *seen* that code, right? ;)
How does it defeat the purpose of __iommu_dma_alloc_pages?
| |