Messages in this thread | | | Date | Fri, 1 Feb 2019 16:45:08 +0100 | From | Boris Brezillon <> | Subject | Re: [PATCH v2 10/10] spi: atmel-quadspi: add support for sam9x60 qspi controller |
| |
On Fri, 1 Feb 2019 14:49:27 +0000 <Tudor.Ambarus@microchip.com> wrote:
> > >>>> +#define QSPI_IFR_APBTFRTYP_READ BIT(24) > > > > And this one would be > > > > define QSPI_IFR_SAM9X60_READ_TRSFR BIT(24) > > I prefer letting this bit named as in the datasheet, QSPI_IFR_APBTFRTYP_READ, > and change it if future versions of the IP will modify its sense. It is a READ > transfer done on APB, it is more generic this way. If you have a strong opinion > on this, please let me know.
As you wish.
| |