Messages in this thread | | | From | Felipe Balbi <> | Subject | Re: [PATCH 12/18] fotg210-udc: remove a bogus dma_sync_single_for_device call | Date | Fri, 01 Feb 2019 15:19:41 +0200 |
| |
Christoph Hellwig <hch@lst.de> writes:
> dma_map_single already transfers ownership to the device. > > Signed-off-by: Christoph Hellwig <hch@lst.de>
Do you want me to take the USB bits or will you take the entire series? In case you're taking the entire series:
Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
> --- > drivers/usb/gadget/udc/fotg210-udc.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/usb/gadget/udc/fotg210-udc.c b/drivers/usb/gadget/udc/fotg210-udc.c > index bc6abaea907d..fe9cf415f2f1 100644 > --- a/drivers/usb/gadget/udc/fotg210-udc.c > +++ b/drivers/usb/gadget/udc/fotg210-udc.c > @@ -356,10 +356,6 @@ static void fotg210_start_dma(struct fotg210_ep *ep, > return; > } > > - dma_sync_single_for_device(NULL, d, length, > - ep->dir_in ? DMA_TO_DEVICE : > - DMA_FROM_DEVICE); > - > fotg210_enable_dma(ep, d, length); > > /* check if dma is done */ > -- > 2.20.1 >
-- balbi [unhandled content-type:application/pgp-signature] | |