lkml.org 
[lkml]   [2019]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] ASoC: cs42l42: add missed regulator_bulk_disable in remove and fix probe failure
    On Tue, Dec 10, 2019 at 12:24 AM Mark Brown <broonie@kernel.org> wrote:
    >
    > On Fri, Dec 06, 2019 at 03:52:09PM +0800, Chuhong Yuan wrote:
    > > The driver forgets to call regulator_bulk_disable() in remove like that
    > > in probe failure.
    > > Besides, some failed branches in probe do not handle failure correctly.
    > > Add the missed call and revise wrong direct returns to fix it.
    >
    > Same issue with runtime PM here.
    >
    > Also please submit one patch per change, each with a clear changelog, as
    > covered in SubmittingPatches. This makes it much easier to review
    > things since it's easier to tell if the patch does what it was intended
    > to do. When splitting patches up git gui can be helpful, you can stage
    > and unstage individual lines by right clicking on them.

    I'm sorry that I didn't notice this problem and these patches should be merged
    into a series.

    I have a question that what if CONFIG_PM is not defined?
    Since I have met runtime PM before in the patch
    a31eda65ba21 ("net: fec: fix clock count mis-match").
    I learned there that in some cases CONFIG_PM is not defined so runtime PM
    cannot take effect.
    Therefore, undo operations should still exist in remove functions.

    Regards,
    Chuhong

    \
     
     \ /
      Last update: 2019-12-09 17:53    [W:6.324 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site