lkml.org 
[lkml]   [2019]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 06/10] extcon: arizona: Remove unnecessary sets of ACCDET_MODE
    Date
    arizona_start_mic sets ACCDET_MODE as required for the microphone
    detection as such it is redundant to set this outside of this function.

    Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
    ---
    drivers/extcon/extcon-arizona.c | 11 -----------
    1 file changed, 11 deletions(-)

    diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
    index 5ae111ee3d631..e7c198e798e27 100644
    --- a/drivers/extcon/extcon-arizona.c
    +++ b/drivers/extcon/extcon-arizona.c
    @@ -668,11 +668,6 @@ static irqreturn_t arizona_hpdet_irq(int irq, void *data)
    if (id_gpio)
    gpio_set_value_cansleep(id_gpio, 0);

    - /* Revert back to MICDET mode */
    - regmap_update_bits(arizona->regmap,
    - ARIZONA_ACCESSORY_DETECT_MODE_1,
    - ARIZONA_ACCDET_MODE_MASK, ARIZONA_ACCDET_MODE_MIC);
    -
    /* If we have a mic then reenable MICDET */
    if (mic || info->mic)
    arizona_start_mic(info);
    @@ -732,9 +727,6 @@ static void arizona_identify_headphone(struct arizona_extcon_info *info)
    arizona_extcon_hp_clamp(info, false);
    pm_runtime_put_autosuspend(info->dev);

    - regmap_update_bits(arizona->regmap, ARIZONA_ACCESSORY_DETECT_MODE_1,
    - ARIZONA_ACCDET_MODE_MASK, ARIZONA_ACCDET_MODE_MIC);
    -
    /* Just report headphone */
    ret = extcon_set_state_sync(info->edev, EXTCON_JACK_HEADPHONE, true);
    if (ret != 0)
    @@ -789,9 +781,6 @@ static void arizona_start_hpdet_acc_id(struct arizona_extcon_info *info)
    return;

    err:
    - regmap_update_bits(arizona->regmap, ARIZONA_ACCESSORY_DETECT_MODE_1,
    - ARIZONA_ACCDET_MODE_MASK, ARIZONA_ACCDET_MODE_MIC);
    -
    /* Just report headphone */
    ret = extcon_set_state_sync(info->edev, EXTCON_JACK_HEADPHONE, true);
    if (ret != 0)
    --
    2.11.0
    \
     
     \ /
      Last update: 2019-12-09 12:09    [W:3.502 / U:0.360 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site