Messages in this thread | | | Date | Mon, 9 Dec 2019 19:18:10 -0800 | From | "Paul E. McKenney" <> | Subject | Re: [rcu:dev.2019.12.08a 37/105] net/tipc/crypto.c:261:39: error: implicit declaration of function 'lockdep_is_held'; did you mean 'lockdep_rtnl_is_held'? |
| |
On Tue, Dec 10, 2019 at 09:38:21AM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2019.12.08a > head: 27628657c4a5dc4ed361a933fd368059d1653ac2 > commit: 60a637364607f8086690fe03d31ca2f255c6e79e [37/105] rcu: Remove rcu_swap_protected() > config: c6x-allyesconfig (attached as .config) > compiler: c6x-elf-gcc (GCC) 7.5.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > git checkout 60a637364607f8086690fe03d31ca2f255c6e79e > # save the attached .config to linux build tree > GCC_VERSION=7.5.0 make.cross ARCH=c6x > > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot <lkp@intel.com> > > All errors (new ones prefixed by >>):
Another use slipped in about a month ago! I have queued a patch with your Reported-by fixing it, thank you!
Thanx, Paul
> net/tipc/crypto.c: In function 'tipc_crypto_key_try_align': > net/tipc/crypto.c:261:2: error: implicit declaration of function 'rcu_swap_protected'; did you mean 'rcu_sync_enter'? [-Werror=implicit-function-declaration] > rcu_swap_protected((rcu_ptr), (ptr), lockdep_is_held(lock)) > ^ > net/tipc/crypto.c:1192:3: note: in expansion of macro 'tipc_aead_rcu_swap' > tipc_aead_rcu_swap(rx->aead[key.passive], tmp2, &rx->lock); > ^~~~~~~~~~~~~~~~~~ > >> net/tipc/crypto.c:261:39: error: implicit declaration of function 'lockdep_is_held'; did you mean 'lockdep_rtnl_is_held'? [-Werror=implicit-function-declaration] > rcu_swap_protected((rcu_ptr), (ptr), lockdep_is_held(lock)) > ^ > net/tipc/crypto.c:1192:3: note: in expansion of macro 'tipc_aead_rcu_swap' > tipc_aead_rcu_swap(rx->aead[key.passive], tmp2, &rx->lock); > ^~~~~~~~~~~~~~~~~~ > cc1: some warnings being treated as errors > > vim +261 net/tipc/crypto.c > > fc1b6d6de22087 Tuong Lien 2019-11-08 256 > fc1b6d6de22087 Tuong Lien 2019-11-08 257 #define tipc_aead_rcu_ptr(rcu_ptr, lock) \ > fc1b6d6de22087 Tuong Lien 2019-11-08 258 rcu_dereference_protected((rcu_ptr), lockdep_is_held(lock)) > fc1b6d6de22087 Tuong Lien 2019-11-08 259 > fc1b6d6de22087 Tuong Lien 2019-11-08 260 #define tipc_aead_rcu_swap(rcu_ptr, ptr, lock) \ > fc1b6d6de22087 Tuong Lien 2019-11-08 @261 rcu_swap_protected((rcu_ptr), (ptr), lockdep_is_held(lock)) > fc1b6d6de22087 Tuong Lien 2019-11-08 262 > > :::::: The code at line 261 was first introduced by commit > :::::: fc1b6d6de2208774efd2a20bf0daddb02d18b1e0 tipc: introduce TIPC encryption & authentication > > :::::: TO: Tuong Lien <tuong.t.lien@dektech.com.au> > :::::: CC: David S. Miller <davem@davemloft.net> > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
| |