Messages in this thread Patch in this message | | | From | Jim Cromie <> | Subject | [PATCH v4 03/16] dyndbg: raise verbosity needed to enable ddebug_proc_* logging | Date | Mon, 9 Dec 2019 19:27:29 -0700 |
| |
The verbose/debug logging done by `cat $DBGFS/dynamic_debug/control` is voluminous, and clutters logging done during parsing of queries, which is much more useful when manipulating/enabling callsites.
So increase the required verbosity to 8&9 for per-page and per-line logging; ie ddebug_proc_(start|stop) and ddebug_proc_(show|next) respectively. This leaves 2-7 for any further logging tweaks to the query parsing process.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com> --- lib/dynamic_debug.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 6cefceffadcb..c86c97154657 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -105,12 +105,16 @@ static char *ddebug_describe_flags(struct _ddebug *dp, char *buf, return buf; } -#define vpr_info(fmt, ...) \ +#define vnpr_info(lvl, fmt, ...) \ do { \ - if (verbose) \ + if (verbose >= lvl) \ pr_info(fmt, ##__VA_ARGS__); \ } while (0) +#define vpr_info(fmt, ...) vnpr_info(1, fmt, ##__VA_ARGS__) +#define v8pr_info(fmt, ...) vnpr_info(8, fmt, ##__VA_ARGS__) +#define v9pr_info(fmt, ...) vnpr_info(9, fmt, ##__VA_ARGS__) + static void vpr_info_dq(const struct ddebug_query *query, const char *msg) { /* trim any trailing newlines */ @@ -771,7 +775,7 @@ static void *ddebug_proc_start(struct seq_file *m, loff_t *pos) struct _ddebug *dp; int n = *pos; - vpr_info("called m=%p *pos=%lld\n", m, (unsigned long long)*pos); + v8pr_info("called m=%p *pos=%lld\n", m, (unsigned long long)*pos); mutex_lock(&ddebug_lock); @@ -795,7 +799,7 @@ static void *ddebug_proc_next(struct seq_file *m, void *p, loff_t *pos) struct ddebug_iter *iter = m->private; struct _ddebug *dp; - vpr_info("called m=%p p=%p *pos=%lld\n", + v9pr_info("called m=%p p=%p *pos=%lld\n", m, p, (unsigned long long)*pos); if (p == SEQ_START_TOKEN) @@ -818,7 +822,7 @@ static int ddebug_proc_show(struct seq_file *m, void *p) struct _ddebug *dp = p; char flagsbuf[10]; - vpr_info("called m=%p p=%p\n", m, p); + v9pr_info("called m=%p p=%p\n", m, p); if (p == SEQ_START_TOKEN) { seq_puts(m, @@ -842,7 +846,7 @@ static int ddebug_proc_show(struct seq_file *m, void *p) */ static void ddebug_proc_stop(struct seq_file *m, void *p) { - vpr_info("called m=%p p=%p\n", m, p); + v8pr_info("called m=%p p=%p\n", m, p); mutex_unlock(&ddebug_lock); } -- 2.23.0
| |