lkml.org 
[lkml]   [2019]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/2] irqchip: define EXYNOS_IRQ_COMBINER
    On Sat, 7 Dec 2019 at 14:28, Krzysztof Kozlowski <krzk@kernel.org> wrote:
    >
    > On Sat, Dec 07, 2019 at 10:00:48PM +0900, Hyunki Koo wrote:
    > > From: Hyunki Koo <hyunki00.koo@samsung.com>
    > >
    > > Not all exynos device have IRQ_COMBINER.
    > > Thus add the config for EXYNOS_IRQ_COMBINER.
    > >
    > > Signed-off-by: Hyunki Koo <hyunki00.koo@samsung.com>
    > > ---
    > > drivers/irqchip/Kconfig | 7 +++++++
    > > drivers/irqchip/Makefile | 2 +-
    > > 2 files changed, 8 insertions(+), 1 deletion(-)
    > >
    >
    > Hi,
    >
    > There is no changelog and versioning of this patch so I do not
    > understand how it differs with previous. It's a resend? v2? It brings
    > the confusion and looks like you're ignoring previous comments.
    >
    > Looks the same and looks like breaking Exynos platforms in the same way.
    >
    > If you not want to skip combiner on ARMv8, it makes sense, then please
    > follow the approach we did for Pinctrl drivers (PINCTRL_EXYNOS_ARM and
    > PINCTRL_EXYNOS_ARM64).
    >
    > Best regards,
    > Krzysztof

    Ah, now I see the second patch. Still you break bisect which requires
    specific ordering of patches or squashing them into one. Optionally
    this could be default=y if ARCH_EXYNOS && ARM. I prefer just squashing
    both into one patch in this case.

    >
    > > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
    > > index ba152954324b..3ed7b7f2ae26 100644
    > > --- a/drivers/irqchip/Kconfig
    > > +++ b/drivers/irqchip/Kconfig
    > > @@ -499,4 +499,11 @@ config SIFIVE_PLIC
    > >
    > > If you don't know what to do here, say Y.
    > >
    > > +config EXYNOS_IRQ_COMBINER
    > > + bool "Samsung Exynos IRQ combiner support"

    Now point it to be visible. Only for COMPILE_TEST

    > > + depends on ARCH_EXYNOS

    Since you make it a separate option, make it COMPILE_TEST.

    Best regards,
    Krzysztof

    > > + help
    > > + Say yes here to add support for the IRQ combiner devices embedded
    > > + in Samsung Exynos chips.
    > > +
    > > endmenu
    > > diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile
    > > index e806dda690ea..60d7c7260fc3 100644
    > > --- a/drivers/irqchip/Makefile
    > > +++ b/drivers/irqchip/Makefile
    > > @@ -9,7 +9,7 @@ obj-$(CONFIG_ARCH_BCM2835) += irq-bcm2835.o
    > > obj-$(CONFIG_ARCH_BCM2835) += irq-bcm2836.o
    > > obj-$(CONFIG_DAVINCI_AINTC) += irq-davinci-aintc.o
    > > obj-$(CONFIG_DAVINCI_CP_INTC) += irq-davinci-cp-intc.o
    > > -obj-$(CONFIG_ARCH_EXYNOS) += exynos-combiner.o
    > > +obj-$(CONFIG_EXYNOS_IRQ_COMBINER) += exynos-combiner.o
    > > obj-$(CONFIG_FARADAY_FTINTC010) += irq-ftintc010.o
    > > obj-$(CONFIG_ARCH_HIP04) += irq-hip04.o
    > > obj-$(CONFIG_ARCH_LPC32XX) += irq-lpc32xx.o
    > > --
    > > 2.17.1
    > >

    \
     
     \ /
      Last update: 2019-12-07 14:38    [W:3.738 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site