lkml.org 
[lkml]   [2019]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] virtio-balloon: fix managed page counts when migrating pages between zones
From
Date
On 05.12.19 11:08, Igor Mammedov wrote:
> On Wed, 4 Dec 2019 21:48:07 +0100
> David Hildenbrand <david@redhat.com> wrote:
>
>> In case we have to migrate a ballon page to a newpage of another zone, the
>> managed page count of both zones is wrong. Paired with memory offlining
>> (which will adjust the managed page count), we can trigger kernel crashes
>> and all kinds of different symptoms.
>>
>> One way to reproduce:
>> 1. Start a QEMU guest with 4GB, no NUMA
>> 2. Hotplug a 1GB DIMM and only the memory to ZONE_NORMAL
> ^^^^
> should it be "online" ?

Very right!
[...]

>> mutex_unlock(&vb->balloon_lock);
>>
>> + /* fixup the managed page count (esp. of the zone) */
>> + if (!virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_DEFLATE_ON_OOM)) {
> what happens when balloon has the feature?

With that feature we don't touch the managed page counts at all (see the
other 2 adjust_managed_page_count() callers in this file).

>
>> + adjust_managed_page_count(page, 1);
>> + adjust_managed_page_count(newpage, -1);
>> + }
>> +
>> put_page(page); /* balloon reference */
>>
>> return MIGRATEPAGE_SUCCESS;
>

BTW, I posted a v2 just some minutes ago
(https://lkml.kernel.org/r/20191205092420.6934-1-david@redhat.com)

Thanks!

--
Thanks,

David / dhildenb

\
 
 \ /
  Last update: 2019-12-05 11:13    [W:0.077 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site