Messages in this thread | | | From | Bartosz Golaszewski <> | Date | Thu, 5 Dec 2019 10:28:33 +0100 | Subject | Re: [PATCH v2 09/11] gpiolib: provide a dedicated function for setting lineinfo |
| |
śr., 4 gru 2019 o 23:30 Andy Shevchenko <andy.shevchenko@gmail.com> napisał(a): > > On Wed, Dec 4, 2019 at 6:02 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > We'll soon be filling out the gpioline_info structure in multiple > > places. Add a separate function that given a gpio_desc sets all relevant > > fields. > > > + if (desc->name) { > > + strncpy(info->name, desc->name, sizeof(info->name)); > > + info->name[sizeof(info->name) - 1] = '\0'; > > + } else { > > + info->name[0] = '\0'; > > + } > > + > > + if (desc->label) { > > + strncpy(info->consumer, desc->label, sizeof(info->consumer)); > > + info->consumer[sizeof(info->consumer) - 1] = '\0'; > > + } else { > > + info->consumer[0] = '\0'; > > + } > > I think we have to fix GCC warnings first and then do whatever this patch does. >
What GCC warnings are you referring to exactly?
Bart
> -- > With Best Regards, > Andy Shevchenko
| |