lkml.org 
[lkml]   [2019]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 103/125] powerpc/pseries/dlpar: Fix a missing check in dlpar_parse_cc_property()
    Date
    From: Gen Zhang <blackgod016574@gmail.com>

    [ Upstream commit efa9ace68e487ddd29c2b4d6dd23242158f1f607 ]

    In dlpar_parse_cc_property(), 'prop->name' is allocated by kstrdup().
    kstrdup() may return NULL, so it should be checked and handle error.
    And prop should be freed if 'prop->name' is NULL.

    Signed-off-by: Gen Zhang <blackgod016574@gmail.com>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/powerpc/platforms/pseries/dlpar.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/arch/powerpc/platforms/pseries/dlpar.c b/arch/powerpc/platforms/pseries/dlpar.c
    index 999b04819d699..5abb8e2239a54 100644
    --- a/arch/powerpc/platforms/pseries/dlpar.c
    +++ b/arch/powerpc/platforms/pseries/dlpar.c
    @@ -63,6 +63,10 @@ static struct property *dlpar_parse_cc_property(struct cc_workarea *ccwa)

    name = (char *)ccwa + be32_to_cpu(ccwa->name_offset);
    prop->name = kstrdup(name, GFP_KERNEL);
    + if (!prop->name) {
    + dlpar_free_cc_property(prop);
    + return NULL;
    + }

    prop->length = be32_to_cpu(ccwa->prop_length);
    value = (char *)ccwa + be32_to_cpu(ccwa->prop_offset);
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-12-04 19:17    [W:4.037 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site