Messages in this thread | | | From | Rainer Sickinger <> | Date | Wed, 4 Dec 2019 17:25:14 +0100 | Subject | Re: [PATCH v2 1/4] sched/uclamp: Make uclamp_util_*() helpers use and return UL values |
| |
You can just use Math.clamp for that! Idiots.
RAINER
Am Mi., 4. Dez. 2019 um 17:13 Uhr schrieb Vincent Guittot <vincent.guittot@linaro.org>: > > On Wed, 4 Dec 2019 at 17:03, Valentin Schneider > <valentin.schneider@arm.com> wrote: > > > > On 04/12/2019 15:22, Vincent Guittot wrote: > > >> @@ -2303,15 +2303,15 @@ static inline void cpufreq_update_util(struct rq *rq, unsigned int flags) {} > > >> unsigned int uclamp_eff_value(struct task_struct *p, enum uclamp_id clamp_id); > > > > > > Why not changing uclamp_eff_value to return unsigned long too ? The > > > returned value represents a utilization to be compared with other > > > utilization value > > > > > > > IMO uclamp_eff_value() is a simple accessor to uclamp_se.value > > (unsigned int), which is why I didn't want to change its return type. > > I see it as being the task equivalent of rq->uclamp[clamp_id].value, IOW > > "give me the uclamp value for that clamp index". It just happens to be a > > bit more intricate for tasks than for rqs. > > But then you have to take care of casting the returned value in > several places here and in patch 3 > > > > > uclamp_util() & uclamp_util_with() do explicitly return a utilization, > > so here it makes sense (in my mind, that is) to return UL.
| |